Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smpeg2 new recipe #668

Merged
merged 1 commit into from Jul 22, 2016
Merged

smpeg2 new recipe #668

merged 1 commit into from Jul 22, 2016

Conversation

@Begasus
Copy link
Contributor

Begasus commented Jun 25, 2016

No description provided.

smpeg2$secondaryArchSuffix = 2.0.0 compat >= 2
cmd:smpeg2 = 2.0.0 compat >= 2
cmd:plaympeg$secondaryArchSuffix = 2.0.0 compat >= 2
lib:libsmpeg2$secondaryArchSuffix = 2.0_0.0.0 compat >= 2.0_0

This comment has been minimized.

Copy link
@fbrosson

fbrosson Jun 25, 2016

Member

I think underscores are not allowed for library versioning. All those I have seen so far only have digits and dots.

This comment has been minimized.

Copy link
@Begasus

Begasus Jun 25, 2016

Author Contributor

It's a rework on the smpeg recipe that's in the tree atm, if it needs corrections I would like to hear :)

This comment has been minimized.

Copy link
@Begasus

Begasus Jun 26, 2016

Author Contributor

The created lib is called "libsmpeg2-2.0.so.0.0.0", should I alter this as?:
lib:libsmpeg2$secondaryArchSuffix = 0.0.0 compat >= 0
PS, in the sdl libs I see more "_" in the recipes?

This comment has been minimized.

Copy link
@Begasus

Begasus Jun 26, 2016

Author Contributor

Or should we go with lib:libsmpeg2$secondaryArchSuffix = $portVersion compat >= 2.0.0 ?

This comment has been minimized.

Copy link
@fbrosson

fbrosson Jun 26, 2016

Member

I think it should be just lib:libsmpeg2_2.0$secondaryArchSuffix without any lib versioning because a "2.0" versioning is already in the name of the lib before the ".so". BTW, you might wish to replace the _2.0 by _${portVersion%\.*} to obtain: lib:libsmpeg2_${portVersion%\.*}$secondaryArchSuffix but I don't know if there is a wide acceptance for that. (I've used it in a couple of recipes and it was accepted ;-)

haikuporter has an excellent option that I always use: -S. It enables a strict mode which reports many errors, like, for example, when you forget items for the PROVIDES* or REQUIRES*. So if you forget a dependency on an external lib it will spot it. And if a libname is wrong in the provides, it will also tell you that you don't have a provides for it. I really recommend always using the strict mode. BTW, if you use it on a recipe that has any of the errors it can spot then it will not create the hpkgs, and I like this behaviour ;-)

This comment has been minimized.

Copy link
@Begasus

Begasus Jun 27, 2016

Author Contributor

Using the -S option for a while already, no problems so far

This comment has been minimized.

Copy link
@fbrosson

fbrosson Jun 27, 2016

Member

Sorry, I though you were not using the -S option, but you are.
I though haikuporter would have complained about the «= 2.0_0.0.0 compat >= 2.0_0» but it looks like it does not. So maybe this is not an error after all.

This comment has been minimized.

Copy link
@Begasus

Begasus Jun 27, 2016

Author Contributor

There are a few nice options that can be used with haikuporter :)
If the general feeling about this to change the lib versioning please let me know :)

This comment has been minimized.

Copy link
@Begasus

Begasus Jul 5, 2016

Author Contributor

Any thoughts on this if it needs changing or not?

This comment has been minimized.

Copy link
@waddlesplash

waddlesplash Jul 22, 2016

Member

Since that's what the .so is using, let's keep it.

@fbrosson
Copy link
Member

fbrosson commented Jul 5, 2016

Sorry, I was busy with other recipes and did not test this one yet. I'm trying to build vlc_x86-2.2.1 on x86_gcc2. But I'll give smpeg2 a try asap.

@waddlesplash waddlesplash merged commit 3c5286b into haikuports:master Jul 22, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Begasus Begasus deleted the Begasus:smpeg2 branch Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.