Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upgettext: fix incorrect sed for libasprintf.la on x86 2nd arch. #669
Conversation
The search pattern used in the sed call to fix libasprintf.la did match and work fine on primary architectures, but failed on x86 secondary, resulting in a package that would become invalid if gcc_x86 got upgraded later. The correct search pattern to match e.g. develop/tools/x86/lib/gcc/ is not develop/tools/$relativeLibDir/gcc/ but develop/tools$secondaryArchSubDir/lib/gcc/ and works for all architectures, including secondary, of course.
fbrosson
changed the title
fbrosson
merged commit 9bf608f
into
haikuports:master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fbrosson commentedJun 25, 2016
•
edited
The search pattern used in the sed call to fix
libasprintf.ladid match and work fine on primary architectures, but failed on x86 secondary, resulting in a package that would become invalid if gcc_x86 got upgraded later. The correct search pattern to match e.g.develop/tools/x86/lib/gcc/is notdevelop/tools/$relativeLibDir/gcc/butdevelop/tools$secondaryArchSubDir/lib/gcc/and works for all architectures, including secondary, of course.