Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMSGPACK-C-CPP recipe #836
Merged
MSGPACK-C-CPP recipe #836
Conversation
|
Minor or cosmetic changes. |
| @@ -0,0 +1,94 @@ | |||
| SUMMARY="A serialization library" | |||
| DESCRIPTION="An efficient binary serialization format, which lets you exchange data \ | |||
| among multiple languages like JSON, except that it's faster and smaller. \ | |||
This comment has been minimized.
This comment has been minimized.
fbrosson
Oct 24, 2016
Member
Lines 2 and 3 should be:
DESCRIPTION="An efficient binary serialization format, which lets you exchange \
data among multiple languages like JSON, except that it's faster and smaller. \
| cmd:libtoolize$secondaryArchSuffix | ||
| cmd:make | ||
| cmd:sed | ||
| pkgconfig$secondaryArchSuffix |
This comment has been minimized.
This comment has been minimized.
|
|
||
| PATCH() | ||
| { | ||
| sed -i 's/-pthread/-lroot/g' "example/cpp03/CMakeLists.txt" |
This comment has been minimized.
This comment has been minimized.
fbrosson
Oct 24, 2016
Member
Double quotes are not required here, so you can safely change this to:
sed -i 's/-pthread/-lroot/g' example/cpp03/CMakeLists.txt
|
|
||
| mv $libDir/../libmsgpackc.* $libDir/. | ||
| mv $libDir/../pkgconfig $libDir/. | ||
| mv $prefix/include/* $includeDir/ |
This comment has been minimized.
This comment has been minimized.
fbrosson
Oct 24, 2016
Member
No need to keep trailing «/.» or «/». You can replace these lines by:
mv $libDir/../libmsgpackc.* $libDir
mv $libDir/../pkgconfig $libDir
mv $prefix/include/* $includeDir
That said, if you patch some files and/or pass extra parameters to cmake it might be possible to make «make install» install everything to the correct destinations.
| mv $prefix/include/* $includeDir/ | ||
| rm -rf $prefix/include | ||
|
|
||
| rm -rf $libDir/*.la |
This comment has been minimized.
This comment has been minimized.
fbrosson
Oct 24, 2016
Member
No need for «-r» for the line that removes the libtool files. You can use:
rm -f $libDir/lib*.la
Squashed msgpack recipe MSGPACK-C-CPP recipe Boost Licence Recipe fix Hash fix Fixed recipe, thanks for fbrosson
|
|
||
| BUILD() | ||
| { | ||
| export LDFLAGS="-lroot -lnetwork -lbsd" |
This comment has been minimized.
This comment has been minimized.
|
Ready! |
waddlesplash
merged commit 4b29b0a
into
haikuports:master
1 check passed
1 check passed
dacianf
added a commit
to dacianf/haikuports
that referenced
this pull request
Jan 9, 2017
* Msgpack recipe Squashed msgpack recipe MSGPACK-C-CPP recipe Boost Licence Recipe fix Hash fix Fixed recipe, thanks for fbrosson * Update msgpack_c_cpp-2.0.0.recipe
korli
added a commit
to korli/haikuports
that referenced
this pull request
Jan 26, 2017
* Msgpack recipe Squashed msgpack recipe MSGPACK-C-CPP recipe Boost Licence Recipe fix Hash fix Fixed recipe, thanks for fbrosson * Update msgpack_c_cpp-2.0.0.recipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
extrowerk commentedOct 24, 2016
neovim requires it.