Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haiku2048 #908

Merged
merged 1 commit into from Dec 3, 2016
Merged

Haiku2048 #908

merged 1 commit into from Dec 3, 2016

Conversation

@ohnx
Copy link
Contributor

ohnx commented Dec 3, 2016

Add Haiku2048

Copy link
Member

humdingerb left a comment

Whoever merges has to squash&merge.

@@ -0,0 +1,47 @@
SUMMARY="Clone of the game 2048"

This comment has been minimized.

Copy link
@humdingerb

humdingerb Dec 3, 2016

Member

Suggestion: "The tile-matching game 2048"

SUMMARY="Clone of the game 2048"
DESCRIPTION="Clone of the popular 2048 game.
HOW TO PLAY: Use your arrow keys to move the tiles.

This comment has been minimized.

Copy link
@humdingerb

humdingerb Dec 3, 2016

Member

I'd remove the repeat of the SUMMARY and go with:
"The goal of this popular tile game is get to tile 2048.
Use the cursor keys to move the tiles. When two tiles with the same number
touch, they merge into one."

When two tiles with the same number touch, they merge into one!
Your goal is to get to the 2048 tile!
"

This comment has been minimized.

Copy link
@humdingerb

humdingerb Dec 3, 2016

Member

The closing " should be in the same line as the last DESCRIPTION line.

"
BUILD_PREREQUIRES="
makefile_engine
cmd:gcc

This comment has been minimized.

Copy link
@humdingerb

humdingerb Dec 3, 2016

Member

Use cmd:g++ instead

@ohnx
Copy link
Contributor Author

ohnx commented Dec 3, 2016

@humdingerb Squashed them.

@pulkomandy pulkomandy merged commit 003b8e4 into haikuports:master Dec 3, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fbrosson
Copy link
Member

fbrosson commented Dec 9, 2016

Now that this PR has been merged, the branch it is based on is no longer needed.
You should therefore click "Delete branch" for this PR to get rid of an unneeded branch in your repo. Thanks!
GitHub help: Deleting unused branches

@ohnx ohnx deleted the ohnx:haiku2048 branch Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.