Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upVim patchset: vim GUI requires libstdc++ #916
Merged
Conversation
|
This is great news! Kind reminder to anyone who would like to merge this: please do not use the "Create a merge commit", as we have the "Squash and merge" feature that GitHub has added a few months ago. "Squash and merge" is the prefered merge method. Thanks! |
|
Please, do not merge yet, it is broken on x86. |
|
Are you sure you just don't need to fix the test just the line below ? We don't use gcc4 anymore, do we? |
|
You have right, i'll fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
extrowerk commentedDec 6, 2016
•
edited
With this patch i was able to build it on x64 Haiku.