Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC gfortran recipe #927

Merged
merged 1 commit into from Dec 25, 2016
Merged

GCC gfortran recipe #927

merged 1 commit into from Dec 25, 2016

Conversation

@extrowerk
Copy link
Member

extrowerk commented Dec 13, 2016

Work in progress, Any idea or help really appreciated. See my comments in the recipe.
Thanks!

Copy link
Contributor

korli left a comment

Could you make this change on the current gcc recipe (instead of a new one)? This makes things easier.


SOURCE_URI="https://ftp.gnu.org/gnu/gcc/gcc-5.4.0/gcc-5.4.0.tar.bz2"
CHECKSUM_SHA256="608df76dec2d34de6558249d8af4cbee21eceddbcb580d666f7a5a583ca3303a"
REVISION="4"

This comment has been minimized.

Copy link
@korli

korli Dec 13, 2016

Contributor

You can start over with 1

This comment has been minimized.

Copy link
@extrowerk

extrowerk Dec 13, 2016

Author Member

Anything for love
Oh, I would do anything for love
I would do anything for love, but I won't do that
No, I won't do that

# ----- gfortran_devel package -----------------------------------------------

SUMMARY_gfortran_devel="C/C++-runtime static libraries and C++ headers, needed for gfortran"
DESCRIPTION_syslibs_devel="This package is not of general interest - it \

This comment has been minimized.

Copy link
@korli

korli Dec 13, 2016

Contributor

This still references syslibs.

This comment has been minimized.

Copy link
@extrowerk

extrowerk Dec 13, 2016

Author Member

OMG, thank you!

contains the set of gcc's C/C++-runtime libraries and headers that is \
required by gfortran to build fortran source code."

PROVIDES_gfortran_devel="

This comment has been minimized.

Copy link
@korli

korli Dec 13, 2016

Contributor

I think you can drop _devel (gcc_fortran seems OK).

This comment has been minimized.

Copy link
@extrowerk

extrowerk Dec 13, 2016

Author Member

I did it!

@extrowerk
Copy link
Member Author

extrowerk commented Dec 13, 2016

korli, do you mean, that i should base my changes onto the top of the last 5.4.0 recipe to get a better view what did i changed or do you want it on the top of the gcc6 or 7 recipe? If you want that, i can do it, but please, explain it a bit better. Thanks for your time!

@korli
Copy link
Contributor

korli commented Dec 13, 2016

Yeah please apply your changes to the current gcc5 recipe, bumping revision.

required by gfortran to build fortran source code."

PROVIDES_gfortran="
gcc${secondaryArchSuffix}_gfortran_devel = $portVersion compat >= 5

This comment has been minimized.

Copy link
@fbrosson

fbrosson Dec 13, 2016

Member

Shouldn't this be changed to:

	gcc${secondaryArchSuffix}_gfortran = $portVersion compat >= 5

(i.e. without the _devel suffix) since we' re not defining PROVIDES_gfortran_devel but PROVIDES_gfortran ?

This comment has been minimized.

Copy link
@korli

korli Dec 24, 2016

Contributor

+1

This comment has been minimized.

Copy link
@korli

korli Dec 24, 2016

Contributor

though while at it, could this be named "fortran" instead of "gfortran"? there is already gcc_ als prefix...

@korli
Copy link
Contributor

korli commented Dec 20, 2016

Any update?

@extrowerk
Copy link
Member Author

extrowerk commented Dec 20, 2016

Travelling right now, please be paitent.

@extrowerk extrowerk force-pushed the extrowerk:fortran branch from 0ca4899 to 945caa4 Dec 23, 2016
@extrowerk
Copy link
Member Author

extrowerk commented Dec 23, 2016

Theoretically it is ok now, i'm doing a clean build right now.

@extrowerk
Copy link
Member Author

extrowerk commented Dec 24, 2016

I got this output, have you got any idea, what am i doing wrong?

mimesetting files for package gcc_syslibs-5.4.0_2016_06_04-4-x86_64.hpkg ...
creating package gcc_syslibs-5.4.0_2016_06_04-4-x86_64.hpkg ...
----- Package Info ----------------
header size: 80
heap size: 1040706
TOC size: 1014
package attributes size: 747
total size: 1040786

POLICY ERROR: can't find used library "libquadmath.so.0"
POLICY ERROR: can't find used library "libquadmath.so.0"
POLICY ERROR: can't find used library "libquadmath.so.0"
Error: packaging policy violation(s) in strict mode
keeping chroot folder /Ports/haikuports/sys-devel/gcc/work-5.4.0_2016_06_04 intact for inspection
Error: Build has failed - stopping.

@korli
korli approved these changes Dec 24, 2016
Copy link
Contributor

korli left a comment

Have you tested gfortran?


packageEntries "gfortran_devel" \
$relativeBinDir/gfortran \
$relativeBinDir/x86_64-unknown-haiku-gfortran \ # does it required? what with the "-" symbols? should it be $relativeBinDir/*gfortran

This comment has been minimized.

Copy link
@korli

korli Dec 24, 2016

Contributor

This shouldn't be hard coded.

$relativeLibDir/f951 \
$relativeLibDir/finclude \
$relativeLibDir/libcaf_single.a # is it $installDir/$gccLibDir or $developLibDir \
$relativeLibDir/libgfortran.a \

This comment has been minimized.

Copy link
@korli

korli Dec 24, 2016

Contributor

This goes in the package syslibs _devel.

required by gfortran to build fortran source code."

PROVIDES_gfortran="
gcc${secondaryArchSuffix}_gfortran_devel = $portVersion compat >= 5

This comment has been minimized.

Copy link
@korli

korli Dec 24, 2016

Contributor

+1

required by gfortran to build fortran source code."

PROVIDES_gfortran="
gcc${secondaryArchSuffix}_gfortran_devel = $portVersion compat >= 5

This comment has been minimized.

Copy link
@korli

korli Dec 24, 2016

Contributor

though while at it, could this be named "fortran" instead of "gfortran"? there is already gcc_ als prefix...

@@ -301,6 +315,18 @@ INSTALL()
$relativeLibDir/libstdc++.so.$libstdcxxLibVersion \
$relativeLibDir/libsupc++.so

packageEntries "gfortran" \

This comment has been minimized.

Copy link
@korli

korli Dec 24, 2016

Contributor

"gfortran" => "fortran"


SUMMARY_gfortran="C/C++-runtime static libraries and C++ headers, needed for gfortran"
DESCRIPTION_gfortran="This package is not of general interest - it \
contains the set of gcc's C/C++-runtime libraries and headers that is \

This comment has been minimized.

Copy link
@korli

korli Dec 24, 2016

Contributor

gfortran => fortran

devel:libcaf_single$secondaryArchSuffix = $libgfortranLibVersion compat >= $libgfortranSoVersion
devel:libgfortranbegin$secondaryArchSuffix = $libgfortranLibVersion compat >= $libgfortranSoVersion
"
REQUIRES_gfortran="

This comment has been minimized.

Copy link
@korli

korli Dec 24, 2016

Contributor

_gfortran => _fortran

$relativeLibDir/libgfortran.spec # ? Does it required? \
$relativeLibDir/libgfortranbegin.a

rm -rf $installDir/$gccLibDir/{f951, finclude, libcaf_single*, libgfortran*} # we don't want to include them into other packages

This comment has been minimized.

Copy link
@korli

korli Dec 24, 2016

Contributor

The comment should be on the previous line.

devel:libgfortranbegin$secondaryArchSuffix = $libgfortranLibVersion compat >= $libgfortranSoVersion
"
REQUIRES_fortran="
#gcc${secondaryArchSuffix}_syslibs = $portVersion compat >= 4

This comment has been minimized.

Copy link
@korli

korli Dec 24, 2016

Contributor

I'd uncomment this line, compat should be >= 5

@extrowerk extrowerk force-pushed the extrowerk:fortran branch from badb20f to ea1585a Dec 24, 2016
@extrowerk
Copy link
Member Author

extrowerk commented Dec 24, 2016

Doing a build right now, i'll report back later.
@korli: what do you think about the libquadmath requiment? (See the recipe)

@extrowerk
Copy link
Member Author

extrowerk commented Dec 24, 2016

Tested, works correctly.
20ee39f3e31c4a2d821f85d89b5029e2

It can compile BLAS:
2c9fe47fa4df4675895f44132f307484

Or LAPACK:
4699ffba233f436d9d823cab655e52bc

@extrowerk extrowerk force-pushed the extrowerk:fortran branch from 7b17cf2 to fc5289e Dec 24, 2016
@extrowerk extrowerk changed the title GCC Gfortran WIP recipe GCC gfortran recipe Dec 24, 2016
@extrowerk
Copy link
Member Author

extrowerk commented Dec 24, 2016

The last change made it possible to get the lapack test 100% passed. I think it should be OK now.
@koli: please, check it, and if it is ok, then you can merge it. Thanks!

Copy link
Contributor

korli left a comment

Please restore the build section. You know you just need to touch the build flag to avoid a rebuild, right ?

@extrowerk extrowerk force-pushed the extrowerk:fortran branch from fc5289e to 86349bc Dec 24, 2016
@extrowerk
Copy link
Member Author

extrowerk commented Dec 24, 2016

Thanks for the tip!
The build section is uncommented already.

libquadmath.so and .a should go into syslibs and syslibs_devel
@waddlesplash waddlesplash merged commit 9c08181 into haikuports:master Dec 25, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
korli added a commit to korli/haikuports that referenced this pull request Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.