Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatrixUnionRows type requirements are narrower than MT.union_rows in Python #4761

Closed
tpoterba opened this issue Nov 13, 2018 · 1 comment
Closed
Assignees
Labels

Comments

@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Nov 13, 2018

In Python, we check that the row.dtype and entry.dtype are the same for all MTs. In scala we assert that the RVDTypes are the same. This means that both requiredness and entry array location can cause problems.

@tpoterba
Copy link
Collaborator Author

@tpoterba tpoterba commented Nov 13, 2018

I've assigned Chris because this will probably be a component of the fix for #4527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants