Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addSequence not in JVM #5306

Closed
konradjk opened this issue Feb 11, 2019 · 3 comments · Fixed by #5308
Closed

addSequence not in JVM #5306

konradjk opened this issue Feb 11, 2019 · 3 comments · Fixed by #5308
Assignees

Comments

@konradjk
Copy link
Collaborator

@konradjk konradjk commented Feb 11, 2019

Easy-peasy to reproduce:

rg = hl.get_reference('GRCh38')
rg.add_sequence('gs://hail-common/references/Homo_sapiens_assembly38.fasta.gz',
                'gs://hail-common/references/Homo_sapiens_assembly38.fasta.fai')

throws:

Py4JError: is.hail.variant.ReferenceGenome.addSequence does not exist in the JVM
@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Feb 11, 2019

this is before initialization?

@konradjk
Copy link
Collaborator Author

@konradjk konradjk commented Feb 11, 2019

like hl.init? no, after

@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Feb 11, 2019

ah, it's just totally broken.

tpoterba added a commit to tpoterba/hail that referenced this issue Feb 11, 2019
danking added a commit that referenced this issue Feb 14, 2019
* Fix add_sequence

fixes #5306

* Add test

* Fix

* liftover uses scala object
tpoterba added a commit to tpoterba/hail that referenced this issue Feb 15, 2019
* Fix add_sequence

fixes hail-is#5306

* Add test

* Fix

* liftover uses scala object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants