Skip to content

[query] Improve code generation of If/Coalesce #10061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2021
Merged

[query] Improve code generation of If/Coalesce #10061

merged 2 commits into from
Feb 18, 2021

Conversation

tpoterba
Copy link
Contributor

No description provided.

@tpoterba
Copy link
Contributor Author

https://gist.github.com/tpoterba/203a24cad9082bfe82e6119bae574f43

@tpoterba
Copy link
Contributor Author 

linear_regression_rows_nd      15.7%    386.143     60.770

@johnc1231
Copy link
Contributor

So this made a big difference across the board. This is why we need benchmarks nightly, would have caught this.

@tpoterba
Copy link
Contributor Author

yep, absolutely.

@danking danking merged commit 24576dd into hail-is:main Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnc1231 johnc1231 johnc1231 approved these changes

Assignees

@johnc1231 johnc1231

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpoterba @johnc1231 @danking