Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Fix EmitParams with incorrect requiredness #10133

Merged
merged 1 commit into from Mar 2, 2021

Conversation

johnc1231
Copy link
Contributor

PRing to test, hopefully will fix Akhil's bug.

Akhil's stack trace top:

Java stack trace:
java.lang.RuntimeException: invoke __m684btree_insert: arg 2: type mismatch:
  got +PBoolean
  expected PBoolean
	at is.hail.expr.ir.EmitCodeBuilder$$anonfun$1.apply(EmitCodeBuilder.scala:132)
	at is.hail.expr.ir.EmitCodeBuilder$$anonfun$1.apply(EmitCodeBuilder.scala:114)
	at scala.collection.TraversableLike$$anonfun$flatMap$1.apply(TraversableLike.scala:241)
	at scala.collection.TraversableLike$$anonfun$flatMap$1.apply(TraversableLike.scala:241)
	at scala.collection.immutable.Range.foreach(Range.scala:160)
	at scala.collection.TraversableLike$class.flatMap(TraversableLike.scala:241)
	at scala.collection.AbstractTraversable.flatMap(Traversable.scala:104)
	at is.hail.expr.ir.EmitCodeBuilder._invoke(EmitCodeBuilder.scala:114)
	at is.hail.expr.ir.EmitCodeBuilder.invokeCode(EmitCodeBuilder.scala:164)
	at is.hail.expr.ir.agg.AppendOnlyBTree.is$hail$expr$ir$agg$AppendOnlyBTree$$insert(AppendOnlyBTree.scala:231)
	at is.hail.expr.ir.agg.AppendOnlyBTree$$anonfun$getF$1$$anonfun$is$hail$expr$ir$agg$AppendOnlyBTree$$anonfun$$insertOrGetAt$1$1.apply$mcV$sp(AppendOnlyBTree.scala:245)
	at is.hail.asm4s.CodeBuilderLike$class.ifx(CodeBuilder.scala:83)
	at is.hail.expr.ir.EmitCodeBuilder.ifx(EmitCodeBuilder.scala:37)
	at is.hail.expr.ir.agg.AppendOnlyBTree$$anonfun$getF$1.is$hail$expr$ir$agg$AppendOnlyBTree$$anonfun$$insertOrGetAt$1(AppendOnlyBTree.scala:244)

case (false, true) => {
EmitCode.fromI(callee) { cb => IEmitCode.present(this, ec.toI(this).get(this))}
}
case _ => ec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get rid of this base case, it's dead code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er, nvm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote the cast out separately like this, figured it'd be easier to delete this cast block and go back to just using ec when we fix the underlying problem.

@danking danking merged commit f62c4a6 into hail-is:main Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants