Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcf-combiner] Add support for haploid GT calls #10251

Merged
merged 2 commits into from Apr 26, 2021

Conversation

chrisvittal
Copy link
Collaborator

No description provided.

Copy link
Contributor

@tpoterba tpoterba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a small test as we talked about?

@chrisvittal
Copy link
Collaborator Author

I've validated correctness for haploid calls manually, and confirmed that results for diploid calls don't change.

@chrisvittal chrisvittal dismissed tpoterba’s stale review April 16, 2021 16:08

test added, should be fixed

@danking danking merged commit 9b264e9 into hail-is:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants