Skip to content

[vcf-combiner] Add support for haploid GT calls - #10251

Merged
danking merged 2 commits into
hail-is:mainfrom
chrisvittal:vcf-combiner/support-haploid
Apr 26, 2021
Merged

danking merged 2 commits into
hail-is:mainfrom
chrisvittal:vcf-combiner/support-haploid

Conversation

@chrisvittal

Copy link
Copy Markdown
Collaborator

No description provided.

@chrisvittal
chrisvittal requested a review from tpoterba March 30, 2021 17:58

@tpoterba tpoterba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a small test as we talked about?

@chrisvittal
chrisvittal force-pushed the vcf-combiner/support-haploid branch from 51e1b36 to 171b686 Compare April 13, 2021 15:03
@chrisvittal
chrisvittal requested a review from tpoterba April 13, 2021 15:04
@chrisvittal

Copy link
Copy Markdown
Collaborator Author

I've validated correctness for haploid calls manually, and confirmed that results for diploid calls don't change.

@chrisvittal
chrisvittal force-pushed the vcf-combiner/support-haploid branch from 171b686 to 1d5451b Compare April 16, 2021 16:08
@chrisvittal
chrisvittal dismissed tpoterba’s stale review April 16, 2021 16:08

test added, should be fixed

@danking
danking merged commit 9b264e9 into hail-is:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants