[query] Fix bad memory leak triggered by set contains IR function#10451
Merged
Conversation
CHANGELOG: Fixed a memory leak triggered by `hl.literal(...).contains(...) This bug is present elsewhere in the code generator, but the set contains function is probably the worst place for it to happen. This leads to a full copy of the set where the binary search is executed. The core problem was a bug in PArrayBackedContainer not casting its codes properly, leading to the no-op coerce logic in PCanonicalArray being bypassed in favor of the generic copy-the-world implementation of `store`. The test I have added catches the memory leak, but now fails at compile time at the assertion to `PCanonicalArray.store` instead.
johnc1231
approved these changes
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG: Fixed a memory leak triggered by `hl.literal(...).contains(...)
This bug is present elsewhere in the code generator, but the set
contains function is probably the worst place for it to happen.
This leads to a full copy of the set where the binary search
is executed.
The core problem was a bug in PArrayBackedContainer not casting
its codes properly, leading to the no-op coerce logic in PCanonicalArray
being bypassed in favor of the generic copy-the-world implementation of
store. The test I have added catches the memory leak, but now fails atcompile time at the assertion to
PCanonicalArray.storeinstead.