Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ndarray map2 #10635

Merged
merged 12 commits into from Jul 7, 2021
Merged

Ndarray map2 #10635

merged 12 commits into from Jul 7, 2021

Conversation

ammekk
Copy link
Contributor

@ammekk ammekk commented Jul 1, 2021

Added nd array map2 to correspond to existing scala nd array map2 ir. Also used map2 to facilitate writing user facing features hl.nd.maximum and hl.nd.minimum which echo np.maximum and np.minimum.

hail/python/hail/nd/nd.py Outdated Show resolved Hide resolved
hail/python/hail/nd/nd.py Outdated Show resolved Hide resolved
hail/python/hail/nd/nd.py Outdated Show resolved Hide resolved
hail/python/hail/nd/nd.py Outdated Show resolved Hide resolved
@@ -3927,7 +3928,7 @@ def reshape(self, *shape):

@typecheck_method(f=func_spec(1, expr_any))
def map(self, f):
"""Transform each element of an NDArray.
"""Applies an element-wise binary operation on an NDArray.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a binary operation for regular map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants