Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] fix read(..., _n_partitions) with missing keys #10697

Merged
merged 2 commits into from Jul 26, 2021

Conversation

danking
Copy link
Contributor

@danking danking commented Jul 23, 2021

I verified the test failed with the same error as KC's before my change.

@tpoterba
Copy link
Contributor

I think this might fail tests with an xpass on local backend.

@danking
Copy link
Contributor Author

danking commented Jul 23, 2021

test_read_partitions fails on the local (I copied the annotations from that test)

@danking
Copy link
Contributor Author

danking commented Jul 26, 2021

Hmm. So. _n_partitions is more like "desired _n_partitions"? Because a key can't be split across multiple partitions.

@danking danking merged commit 98bf0a7 into hail-is:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants