Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Escaping field names that don't start with a letter #10829

Merged
merged 3 commits into from Sep 2, 2021

Conversation

johnc1231
Copy link
Contributor

@johnc1231 johnc1231 commented Aug 31, 2021

My understanding of this now is that we have to backtick-escape any identifiers that aren't going to be valid java/python identifiers. That means we have to change the regex that identifies those to only accept things that start with a letter.

@patrick-schultz
Copy link
Collaborator

Starting with an underscore is safe, isn't it?

@johnc1231
Copy link
Contributor Author

Ah yes, apparently Java considers an underscore to be a "letter": https://docs.oracle.com/javase/specs/jls/se7/html/jls-3.html#jls-3.8

@johnc1231
Copy link
Contributor Author

Addressed

@danking danking merged commit e4b7aa1 into hail-is:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants