[query] Escaping field names that don't start with a letter#10829
Merged
danking merged 3 commits intohail-is:mainfrom Sep 2, 2021
Merged
[query] Escaping field names that don't start with a letter#10829danking merged 3 commits intohail-is:mainfrom
danking merged 3 commits intohail-is:mainfrom
Conversation
…er, as they wont be java identifiers
Member
|
Starting with an underscore is safe, isn't it? |
Contributor
Author
|
Ah yes, apparently Java considers an underscore to be a "letter": https://docs.oracle.com/javase/specs/jls/se7/html/jls-3.html#jls-3.8 |
Contributor
Author
|
Addressed |
patrick-schultz
approved these changes
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My understanding of this now is that we have to backtick-escape any identifiers that aren't going to be valid java/python identifiers. That means we have to change the regex that identifies those to only accept things that start with a letter.