[query] Fix lowered coercers with empty partitions#10878
Merged
danking merged 2 commits intohail-is:mainfrom Sep 15, 2021
Merged
[query] Fix lowered coercers with empty partitions#10878danking merged 2 commits intohail-is:mainfrom
danking merged 2 commits intohail-is:mainfrom
Conversation
patrick-schultz
previously requested changes
Sep 15, 2021
Member
patrick-schultz
left a comment
patrick-schultz
left a comment
There was a problem hiding this comment.
Looks good, other than one preexisting issue. Since it doesn't seem to be causing problems, I'm okay if you want to get this in and fix the other bug later.
| ("maxkey", ArrayRef(GetField(row, "maxkey"), I32(0))))) | ||
| } | ||
| }) { (l, r) => | ||
| ApplyComparisonOp(LT(keyType), GetField(l, "minkey"), GetField(r, "minkey")) |
Member
There was a problem hiding this comment.
You didn't introduce this, but shouldn't this sort on (key, i) lexicographically? Say the partitions are [0, 2], [2, 2], [2, 5], and it sorted by min key to [0, 2], [2, 5], [2, 2]. Then we would decide the data was unsorted.
Contributor
Author
There was a problem hiding this comment.
I can fix this. I think it should sort on (minkey, maxkey) though -- the index shouldn't matter.
I believe the adversarial case is:
[0, 2], [2, 5], [2, 2]
This will be sorted to itself, and will fail the sortedness check in the next phase.
patrick-schultz
approved these changes
Sep 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.