[query] Use EType encodings instead of JSON to send data to Python - #10971
Merged
Conversation
johnc1231
force-pushed
the
johnc-etypes-python
branch
2 times, most recently
from
October 14, 2021 18:41
421d24a to
a22a4ac
Compare
… an array of a couple of ints
… of int structs is slightly faster than JSON equivalent
…depath that correctly handles HailUserErrors
…nd to support encoding
johnc1231
force-pushed
the
johnc-etypes-python
branch
from
October 18, 2021 17:22
e6bce79 to
871985c
Compare
chrisvittal
approved these changes
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timings: https://gist.github.com/johnc1231/253aed65af131c2f67af2576c350d6a7
Basically the benchmark designed for this to fix got 3x better, and most other things didn't change. That's about what I expected.