Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] compute p-value from one-sided HWE test for excess heterozygosity in hl.variant_qc #10993

Merged
merged 2 commits into from
Oct 22, 2021
Merged

[query] compute p-value from one-sided HWE test for excess heterozygosity in hl.variant_qc #10993

merged 2 commits into from
Oct 22, 2021

Conversation

pwc2
Copy link
Contributor

@pwc2 pwc2 commented Oct 19, 2021

This updates hl.variant_qc to compute the p-value from the one-sided HWE test for excess heterozygosity as the field p_value_excess_het.

@pwc2 pwc2 marked this pull request as ready for review October 19, 2021 18:57
tpoterba
tpoterba approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@tpoterba tpoterba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thought I had approved this...

Nice work!

@danking danking merged commit e4be580 into hail-is:main Oct 22, 2021
@pwc2 pwc2 deleted the variant-qc branch November 10, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpoterba tpoterba tpoterba approved these changes

Assignees

@tpoterba tpoterba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pwc2 @tpoterba @danking