[query] Fix bug in call decoding, add error ID to lgt_to_gt #11023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def withErrorID(aj: Int, ak: Int, phased: Boolean, errorID: Int): Call = { | ||
| if (aj < 0 || ak < 0) | ||
| fatal(s"allele indices must be >= 0. Found j=$aj and k=$ak.") |
Member
There was a problem hiding this comment.
Should this be tagged with the errorID too?
Contributor
|
Thanks for catching this, sorry about that. |
Contributor
|
@tpoterba failing the test you wrote |
Contributor
Author
|
yep, will fix when done with docs |
Contributor
Author
|
Commented out the phased test -- this was meant to fail, and I didn't intend to fix that in this PR (it's hard, we need to change the Call representation...) |
Contributor
Author
|
Addressed Patrick's comment. |
patrick-schultz
approved these changes
Nov 2, 2021
pwc2
pushed a commit
to pwc2/hail
that referenced
this pull request
Nov 12, 2021
…11023) * [query] Fix bug in call decoding, add error ID to lgt_to_gt * address comments, comment out phased test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.