Repository navigation
Update docs to remove 3.6 from supported versions - #11219
Conversation
|
hail/python/setup.py: python_requires=">=3.6", Found a few more invocations of 3.6. I'm not sure when you want to update the |
|
I think this covers most spots. I updated the python_requires, left the docker images, tried to update batch docs. |
| @@ -25,7 +25,7 @@ | |||
| from ..hail_logging import Logger | |||
|
|
|||
| if pyspark.__version__ < '3' and sys.version_info > (3, 8): | |||
There was a problem hiding this comment.
If the > symbol there is to be believed should we require 3.7 or 3.8? Or should that be >=?
There was a problem hiding this comment.
If it's >= then maybe that fix is out of scope here since that would be breaking?
There was a problem hiding this comment.
Huh, this must not actually run, since we definitely allow users to use 3.8. I'll investigate, good catch.
There was a problem hiding this comment.
Oh wait, I remember now. This is because Spark 2 can't use > 3.8. So yeah, 3.7 is the only ok version, that's fine. I plan on dropping Spark 2 support shortly anyway.
Follow up to #11206. Python 3.6 is EOL, so let's not claim to support it or encourage its use anymore.