Introduce Hail version of ggplot #11247
Conversation
geom_text added
Add Labels and Stats
added bar graphs and histograms
x and y axis labels
…rate lines, and geom_point geom_line and geom_text all use same color handling code
… as is labeling the legend appropriately
added tiles and tooltips
| self.breaks = breaks | ||
| self.labels = labels | ||
|
|
||
| def update_axis(self, fig): |
There was a problem hiding this comment.
this seems like its not meant to be used only by subclasses, right? Let's prefix it with an underscore to indicate that.
There was a problem hiding this comment.
It's meant to be used by GGPlot in order to update the axes of a plot with things like ticks, labels, etc.
| @typecheck_method(contig=str) | ||
| def _contig_global_position(self, contig): | ||
| @property | ||
| def _global_positions_dict(self): |
There was a problem hiding this comment.
Hmm. Any reason to not make this part of the public API (make it not underscore)? If we're referencing it in the plotting functionality, then it must be generally useful, yeah?
There was a problem hiding this comment.
Forgot this was in there, modified quickly as part of a "genomic" scale experiment. Will clean up and make it not _.
danking
left a comment
danking
left a comment
There was a problem hiding this comment.
a few drive-by thoughts. It'd be great to add type annotations as well! I find they're useful when exploring a new library, but I realize they're pretty rare in Hail Query code.
|
Addressed @danking's comments, though I'm not going to attempt to add type information in this PR, given intended timeline for release and other commitments. |
patrick-schultz
left a comment
patrick-schultz
left a comment
There was a problem hiding this comment.
This is really great! I know we want to release this today, so just a few small things.
hail/python/hail/ggplot/utils.py
Outdated
|
|
||
| if scale.is_discrete() and not is_discrete_type(dtype): | ||
| raise ValueError(f"Aesthetic {aes_key} has continuous dtype but non continuous scale") | ||
| if not scale.is_discrete() and is_discrete_type(dtype): |
There was a problem hiding this comment.
Should this check not is_continuous_type(dtype) instead? More generally, is_discrete_type and is_continuous_type are not complements, and it's not clear to me if that is intentional.
There was a problem hiding this comment.
Yeah, this is true. Just went and added a is_continuous method on scale to address this. I think they were briefly complementary though that was an oversimplification
|
@patrick-schultz Addressed your comments, and made the docs a little better. |
4 participants
No description provided.