Skip to content

Distinct analysis#11306

Merged
danking merged 11 commits into
hail-is:mainfrom
ammekk:distinct-analysis
Feb 25, 2022
Merged

Distinct analysis#11306
danking merged 11 commits into
hail-is:mainfrom
ammekk:distinct-analysis

Conversation

@ammekk
Copy link
Copy Markdown
Contributor

@ammekk ammekk commented Feb 1, 2022

Analysis pass to decide if tableIRs are uniquely keyed. Used by table join.

Comment thread hail/src/main/scala/is/hail/expr/ir/Analyses.scala Outdated
@ammekk ammekk marked this pull request as ready for review February 8, 2022 16:58
Comment thread hail/src/main/scala/is/hail/expr/ir/DistinctlyKeyed.scala Outdated
Comment thread hail/src/test/scala/is/hail/expr/ir/DistinctlyKeyedSuite.scala Outdated
Comment thread hail/src/test/scala/is/hail/expr/ir/DistinctlyKeyedSuite.scala Outdated
@ammekk ammekk force-pushed the distinct-analysis branch from 7e06682 to 944c4fd Compare February 8, 2022 20:13
@johnc1231
Copy link
Copy Markdown
Contributor

Still some build errors coming from tests

@ammekk ammekk dismissed johnc1231’s stale review February 22, 2022 18:14

addressed comments

@johnc1231
Copy link
Copy Markdown
Contributor

@danking danking merged commit dec7d25 into hail-is:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants