[compiler] explicitly provide type infos for array loads #11331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpoterba
changed the title
tpoterba
force-pushed
the
array-load-insn
branch
from
4d8a6af to
9e733e8
Compare
patrick-schultz
previously requested changes
Feb 8, 2022
| class CodeArray[T](val lhs: Code[Array[T]])(implicit tti: TypeInfo[T]) { | ||
| def apply(i: Code[Int]): Code[T] = | ||
| Code(lhs, i, lir.insn2(tti.aloadOp)) | ||
| Code(lhs, i, { case (v1: ValueX, v2: ValueX) => lir.insn(tti.aloadOp, tti, FastIndexedSeq(v1, v2)) }) |
Member
There was a problem hiding this comment.
Could we add some typechecking here that tti == v1.tti.tti? (I think that is the right check...)
Contributor
Author
There was a problem hiding this comment.
we should add this on the CodeArray constructor if anywhere, not in the body here. I'll do that.
Merged
Contributor
|
Seems like review can be dismissed? |
Contributor
Author
|
yes, thanks. |
patrick-schultz
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.