Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geom area #11332

Merged
merged 7 commits into from
Feb 11, 2022
Merged

Geom area #11332

merged 7 commits into from
Feb 11, 2022

Conversation

ammekk
Copy link
Contributor

@ammekk ammekk commented Feb 8, 2022

Added new geom, geom_area and fixed bug with scale_color_continuous

johnc1231
johnc1231 previously requested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@johnc1231 johnc1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things to do:

geom_area needs a docstring saying what aesthetics it supports. Look at the others.
geom_area has to be added to: /hail/hail/python/hail/docs/ggplot/index.rst

johnc1231
johnc1231 previously requested changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@johnc1231 johnc1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing and we'll be good to go with this one, good work.

hail/python/hail/ggplot/geoms.py Outdated Show resolved Hide resolved
hail/python/hail/ggplot/geoms.py Show resolved Hide resolved
@danking danking merged commit 40d8882 into hail-is:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnc1231 johnc1231 johnc1231 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ammekk @johnc1231 @danking