[query] from_pandas needs to support Pandas missing types and support numpy nums better #11401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas missingness is crazy.
pd.isnatells you if something is "missing", which means eitherNaN, or a specialNAsentinel value. For floats they useNaN, and specifically for the pandas specialInt64DTypeandInt32DTypeand nothing else they use thisNAvalue.They don't have an easy way to distinguish between
NAandNaN, so I first check if somethingisna, then check if it's afloatto differentiate between the cases.They also don't have a way to test if something is a
Int32DTypefor some reason. So I useis_int64_dtype, and if that fails I fall back tois_integer_dtype, which is true for bothInt64DTypeandInt32DType.