[query/service] make available driver progress information #11746
Merged
Conversation
added 8 commits
April 1, 2022 15:42
These changes make it straightforward to always use QoB by default.
It now looks like this: ``` In [2]: import hail as hl ...: t = hl.utils.range_table(100) ...: t._force_count() ...: t.show() Submitted batch 1774275, see https://batch.hail.is/batches/1774275/jobs/1 Batch 1774275: completed jobs: 100%|████████████████████████████████████████████████████████████████████| 1/1 [00:14<00:00, 14.76s/it] Submitted batch 1774315, see https://batch.hail.is/batches/1774315/jobs/1 Batch 1774315: completed jobs: 100%|████████████████████████████████████████████████████████████████████| 1/1 [01:03<00:00, 63.06s/it] +-------+ | idx | +-------+ | int32 | +-------+ | 0 | | 1 | | 2 | | 3 | | 4 | | 5 | | 6 | | 7 | | 8 | | 9 | | 10 | | 11 | | 12 | | 13 | +-------+ showing top 14 rows ```
Contributor
Author
|
stacked on #11745 |
Contributor
Author
|
@tpoterba I have two concrete questions for you here:
|
Contributor
|
Contributor
|
@chrisvittal can you comment on this second point? |
Collaborator
|
For flag style env variables, I think we should use present and non-empty. We could also go with a reasonable set of 'affirmative' values, like say (all case insensitive) |
Contributor
Author
|
I'll go with present and non-empty. |
Contributor
Author
|
OK, ready for review. |
tpoterba
approved these changes
May 13, 2022
tpoterba
left a comment
Contributor
There was a problem hiding this comment.
oops, didn't realize this was hanging on me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now looks like this: