[query] add max_iterations and tolerance parameters to all iterative regressions #11759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danking
force-pushed
the
max-iter-for-non-linear-regressions
branch
from
ecfc369 to
99877f6
Compare
tpoterba
approved these changes
Apr 14, 2022
Contributor
tpoterba
left a comment
tpoterba
left a comment
There was a problem hiding this comment.
looks good. This PR would have been so tiny if we could delete the Scala implementation today :(
…regressions CHANGELOG: `hl.logistic_regression_rows`, `hl.poisson_regression_rows`, and `hl.skat` all now support configuration of the maximum number of iterations and the tolerance. This was requested [on Zulip](https://hail.zulipchat.com/#narrow/stream/127634-Feature-Requests/topic/Convergence.20issues.20with.20hl.2Elogistic_regression_rows).
danking
force-pushed
the
max-iter-for-non-linear-regressions
branch
from
99877f6 to
20973b0
Compare
added 2 commits
April 15, 2022 13:17
danking
force-pushed
the
max-iter-for-non-linear-regressions
branch
from
91fdcd3 to
b5058a1
Compare
added 11 commits
April 20, 2022 15:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG:
hl.logistic_regression_rows,hl.poisson_regression_rows, andhl.skatall now support configuration of the maximum number of iterations and the tolerance.I had to make some fixes to how we count the number of iterations. It was quite screwy. Now it should reliably report the correct number of iterations regardless of failure, non-convergence, or explosion.
This was requested on Zulip.