[query] Remove unsupported LMM code#11765
Merged
danking merged 2 commits intohail-is:mainfrom Apr 14, 2022
Merged
Conversation
CHANGELOG: Deprecated and removed linear mixed model functionality.
danking
previously requested changes
Apr 14, 2022
hail/python/hail/methods/statgen.py
Outdated
| assert n > m | ||
| p = BlockMatrix.read(p_path) | ||
| return model, p | ||
| raise NotImplementedError("linear_mixed_modelv is no longer implemented/supported as of Hail 0.2.94") |
Contributor
There was a problem hiding this comment.
Suggested change
| raise NotImplementedError("linear_mixed_modelv is no longer implemented/supported as of Hail 0.2.94") | |
| raise NotImplementedError("linear_mixed_model is no longer implemented/supported as of Hail 0.2.94") |
hail/python/hail/methods/statgen.py
Outdated
|
|
||
| mt_keys = mt.select_rows(**row_fields).add_row_index('__row_idx').rows().add_index('__row_idx').key_by('__row_idx') | ||
| return mt_keys.annotate(**ht[mt_keys['__row_idx']]).key_by(*mt.row_key).drop('__row_idx') | ||
| raise NotImplementedError("linear_mixed_modelv is no longer implemented/supported as of Hail 0.2.94") |
Contributor
There was a problem hiding this comment.
Suggested change
| raise NotImplementedError("linear_mixed_modelv is no longer implemented/supported as of Hail 0.2.94") | |
| raise NotImplementedError("linear_mixed_model is no longer implemented/supported as of Hail 0.2.94") |
Contributor
Author
|
fixed! |
danking
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG: Deprecated and removed linear mixed model functionality.