[query] import_table: simplify code and improve speed #11782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2022 12:45
CHANGELOG: `hl.import_table` is up to twice as fast for small tables. I mostly abstracted things and simplified code. One big change is optimizing for the single file, no filters case in which we need not scan for the first extant row, that row *must* be in the first partition, if it exists at all.
Contributor
|
can give this one to Chris, who's worked on this most recently |
CDiaz96
pushed a commit
to CDiaz96/hail
that referenced
this pull request
Apr 27, 2022
* [query] import_table: simplify code and improve speed CHANGELOG: `hl.import_table` is up to twice as fast for small tables. I mostly abstracted things and simplified code. One big change is optimizing for the single file, no filters case in which we need not scan for the first extant row, that row *must* be in the first partition, if it exists at all. * handle empty files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG:
hl.import_tableis up to twice as fast for small tables.The big change is optimizing for the single file, no filters case in which
we need not scan for the first extant row, that row must be in the first
partition, if it exists at all. Unfortunately there is no zero-RPC way to
determine the number of partitions in a table, so I must catch an error
about the lack of a zeroth partition.
I also did some refactoring:
hl.formatfor constructing strings.should_filter_lineintoshould_remove_linefor clarity of name.should_remove_lineto use short-circuiting and/or instead of array folds.should_remove_lineto indicate (via returning None) when there are no filters enabled..collect()[0]would beNoneif there were no values in the table. (It raises an error)hail.utils.deduplicate(haha: I mean, there is already code for doing field dedupe)