[query] Fix text export part file overwrite due to speculation#11910
Merged
danking merged 1 commit intohail-is:mainfrom Jun 14, 2022
Merged
[query] Fix text export part file overwrite due to speculation#11910danking merged 1 commit intohail-is:mainfrom
danking merged 1 commit intohail-is:mainfrom
Conversation
tpoterba
approved these changes
Jun 14, 2022
Contributor
|
looks good! |
We do not make guarantees about the exact contents of a folder after a parallel export. We do guarantee that all data is in the folder however, so we must make it speculation safe. We do so by adding a UUID to each part file we write for in lowered text export.
chrisvittal
force-pushed
the
lowering/fix-speculation-overwrite
branch
from
a33de55 to
70dbb3c
Compare
chrisvittal
added a commit
to chrisvittal/hail
that referenced
this pull request
Jun 16, 2022
This fixes an issue introduced by hail-is#11910, where extra part files may be created by speculative execution. This is an issue for parallel export where we did not delete any files. Now we list the output directory, and compare it to the proper list of files. The paths that are not in the list of 'good' paths are deleted.
chrisvittal
added a commit
to chrisvittal/hail
that referenced
this pull request
Jun 17, 2022
This fixes an issue introduced by hail-is#11910, where extra part files may be created by speculative execution. This is an issue for parallel export where we did not delete any files. Now we list the output directory, and compare it to the proper list of files. The paths that are not in the list of 'good' paths are deleted.
danking
pushed a commit
that referenced
this pull request
Jun 17, 2022
This fixes an issue introduced by #11910, where extra part files may be created by speculative execution. This is an issue for parallel export where we did not delete any files. Now we list the output directory, and compare it to the proper list of files. The paths that are not in the list of 'good' paths are deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not make guarantees about the exact contents of a folder after
a parallel export. We do guarantee that all data is in the folder
however, so we must make it speculation safe. We do so by adding a UUID
to each part file we write for in lowered text export.