[query] Remove unexpected files from parallel text exports#11921
Merged
danking merged 1 commit intohail-is:mainfrom Jun 17, 2022
Merged
Conversation
danking
approved these changes
Jun 16, 2022
chrisvittal
commented
Jun 17, 2022
Comment on lines
+514
to
+516
| val outputFiles = fs.listStatus(outputPath).map(_.getPath).toSet | ||
| outputFiles.diff(files.toSet).foreach(fs.delete(_, false)) | ||
| val fileset = files.toSet | ||
| val diff = outputFiles.diff(fileset) |
Collaborator
Author
There was a problem hiding this comment.
In the local backend, fs.listStatus is returning results with paths being URIs with the file scheme, causing this set difference to return every file in the directory on the local backend. I'm not sure how to get around this.
Contributor
There was a problem hiding this comment.
I don't have a systemic fix (we really need to get everything on one file system implementation and agree on what scheme (if any) local paths have). The rapid fix is to use fs.canonicalize_path.
Collaborator
Author
There was a problem hiding this comment.
I chose to canonicalize the paths in the cleanup method.
This fixes an issue introduced by hail-is#11910, where extra part files may be created by speculative execution. This is an issue for parallel export where we did not delete any files. Now we list the output directory, and compare it to the proper list of files. The paths that are not in the list of 'good' paths are deleted.
chrisvittal
force-pushed
the
lowering/better-speculation-overwrite-fix
branch
from
e18b143 to
b6d74c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced by #11910, where extra part files may be
created by speculative execution. This is an issue for parallel export
where we did not delete any files.
Now we list the output directory, and compare it to the proper list of
files. The paths that are not in the list of 'good' paths are deleted.