[vcf combiner] Fix error in determining intermidiate file names#11962
Merged
danking merged 1 commit intohail-is:mainfrom Jun 27, 2022
Merged
[vcf combiner] Fix error in determining intermidiate file names#11962danking merged 1 commit intohail-is:mainfrom
danking merged 1 commit intohail-is:mainfrom
Conversation
We were not properly handling cases where there were exactly 10 or 100 files to write. We would handle all other cases correctly. Closes hail-is#11891
danking
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not properly handling cases where there were exactly 10 or 100
files to write. We would handle all other cases correctly.
Closes #11891