[query] Allow seeks more than MAX_INT bytes away #12164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-goldstein
commented
Sep 8, 2022
| // 256 * 8MiB = 2GiB | ||
| while (i < 256) { | ||
| os.write(eight_mib, 0, Int.MaxValue) | ||
| i += 1 |
There was a problem hiding this comment.
I clearly can't write scala 🤦
danking
approved these changes
Sep 8, 2022
danking
previously requested changes
Sep 8, 2022
| val f = t() | ||
| using (fs.create(f)) { os => | ||
| val eight_mib = Array.fill(8 * 1024 * 1024){0.toByte} | ||
| val i = 0 |
There was a problem hiding this comment.
Suggested change
| val i = 0 | |
| var i = 0 |
danking
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assert is here because the buffer we use in the FS is a Java array and can't be longer than MAX_INT, but clearly the position in the blob can be more than that. This currently breaks range reads into indexes on data that's more than 2GiB.