Repository navigation
[pip] Update dependencies and fix batch docs search - #12215
Merged
Merged
Conversation
daniel-goldstein
force-pushed
the
fix-batch-docs-search
branch
from
September 27, 2022 13:37
a4868f7 to
1c19a9f
Compare
jigold
approved these changes
Sep 28, 2022
danking
pushed a commit
to danking/hail
that referenced
this pull request
Feb 29, 2024
I think the latter triggered us to pin the former. See hail-is#12215 for the PR which pinned protobuf. See [the google-cloud-profiler changelog for 4.0.0](https://github.com/GoogleCloudPlatform/cloud-profiler-python/blob/main/CHANGELOG.md#400) for confirmation that google-cloud-profiler was previously incompatible with protobuf >3.20
danking
pushed a commit
to danking/hail
that referenced
this pull request
Feb 29, 2024
I think the latter triggered us to pin the former. See hail-is#12215 for the PR which pinned protobuf. See [the google-cloud-profiler changelog for 4.0.0](https://github.com/GoogleCloudPlatform/cloud-profiler-python/blob/main/CHANGELOG.md#400) for confirmation that google-cloud-profiler was previously incompatible with protobuf >3.20
danking
pushed a commit
to danking/hail
that referenced
this pull request
Feb 29, 2024
I think the latter triggered us to pin the former. See hail-is#12215 for the PR which pinned protobuf. See [the google-cloud-profiler changelog for 4.0.0](https://github.com/GoogleCloudPlatform/cloud-profiler-python/blob/main/CHANGELOG.md#400) for confirmation that google-cloud-profiler was previously incompatible with protobuf >3.20
daniel-goldstein
pushed a commit
to daniel-goldstein/hail
that referenced
this pull request
Mar 4, 2024
I think the latter triggered us to pin the former. See hail-is#12215 for the PR which pinned protobuf. See [the google-cloud-profiler changelog for 4.0.0](https://github.com/GoogleCloudPlatform/cloud-profiler-python/blob/main/CHANGELOG.md#400) for confirmation that google-cloud-profiler was previously incompatible with protobuf >3.20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search bar for the batch docs is broken and just says
Searching…forever. Tracked it down to a bug in thesphinx_rtd_themedependency that was fixed in a later release. The important files to look at are therequirements.txtfiles not thepinned-requirements.txtfiles as the latter bulk updated a bunch of patch releases when I regenerated them.In the mess of version conflicts that updating a dependency appears to do here, I also removed
google-cloud-loggingas it appears to be an unused dependency andpre-commitbecause it is optional for developers and had a hard requirement on aimportlib-metadataversion that made it incompatible with other important libraries that we use. I also explicitly pinnedprotobufas a major version upgrade that wasn't restricted by some google libraries we use broke those same google libraries that added that dependency.