[query] Redesign staged index reading to compute index then query by index #12305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-schultz
requested changes
Oct 12, 2022
| @@ -147,31 +143,69 @@ class StagedIndexReader(emb: EmitMethodBuilder[_], spec: AbstractIndexSpec) { | |||
| } | |||
|
|
|||
| // returns queryType | |||
There was a problem hiding this comment.
out of date comment
patrick-schultz
approved these changes
Oct 12, 2022
…index CHANGELOG: Fixes a rare crash reading tables/matrixtables with _intervals
tpoterba
force-pushed
the
fix-index-boundary
branch
from
0b0bc86
to
7286014
Compare
lgruen
added a commit
to populationgenomics/hail
that referenced
this pull request
Oct 12, 2022
Upstream merge to pick up hail-is#12305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG: Fixes a rare crash reading tables/matrixtables with _intervals