Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qob][batch] replace tqdm with rich #12346

Merged
merged 8 commits into from
Oct 19, 2022

Conversation

danking
Copy link
Contributor

@danking danking commented Oct 17, 2022

There's a kind of unrelated thing: Fix reading of configuration information to not ignore a hailctl configuration value of ''

The big change is to introduce 3 progress bar systems:

  1. SimpleRichProgressBar. One progress bar active at a time.
  2. RichProgressBar. More than one progress bar active at a time.
  3. BatchProgressBar. Same as RichProgressBar but with default columns good for monitoring 1 or more Hail Batch batches.

@daniel-goldstein
Copy link
Contributor

@danking I think you have to add rich to the hail/python dependencies. Docker gets it by accident through twine.

Copy link
Contributor

@daniel-goldstein daniel-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems reasonable. I think if we can change the color of the completed portion of the bar from red to green that would be great (and even better if the failed jobs can show up as red but also happy to defer that change)

self.progress = Progress(*args, **kwargs)

def get_default_columns(self) -> Tuple[ProgressColumn, ...]:
return Progress.get_default_columns() + (TimeElapsedColumn(),)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might get a lint error where this should be a staticmethod

@danking danking dismissed daniel-goldstein’s stale review October 18, 2022 15:46

we now use green for the bar; having multiple components to the bar is a fairly large undertaking because I have to muck around with the bar itself.

@danking
Copy link
Contributor Author

danking commented Oct 18, 2022

batch-pbar
qob-pbar
qob-jupyter
batch-jupyter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants