-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qob][batch] replace tqdm with rich #12346
Conversation
@danking I think you have to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems reasonable. I think if we can change the color of the completed portion of the bar from red to green that would be great (and even better if the failed jobs can show up as red but also happy to defer that change)
self.progress = Progress(*args, **kwargs) | ||
|
||
def get_default_columns(self) -> Tuple[ProgressColumn, ...]: | ||
return Progress.get_default_columns() + (TimeElapsedColumn(),) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might get a lint error where this should be a staticmethod
we now use green for the bar; having multiple components to the bar is a fairly large undertaking because I have to muck around with the bar itself.
There's a kind of unrelated thing: Fix reading of configuration information to not ignore a hailctl configuration value of
''
The big change is to introduce 3 progress bar systems: