[qob][batch] replace tqdm with rich#12346
Merged
danking merged 8 commits intohail-is:mainfrom Oct 19, 2022
Merged
Conversation
Contributor
|
@danking I think you have to add |
daniel-goldstein
previously requested changes
Oct 18, 2022
Contributor
daniel-goldstein
left a comment
daniel-goldstein
left a comment
There was a problem hiding this comment.
This all seems reasonable. I think if we can change the color of the completed portion of the bar from red to green that would be great (and even better if the failed jobs can show up as red but also happy to defer that change)
| self.progress = Progress(*args, **kwargs) | ||
|
|
||
| def get_default_columns(self) -> Tuple[ProgressColumn, ...]: | ||
| return Progress.get_default_columns() + (TimeElapsedColumn(),) |
Contributor
There was a problem hiding this comment.
Might get a lint error where this should be a staticmethod
added 2 commits
October 18, 2022 11:39
danking
dismissed
daniel-goldstein’s stale review
we now use green for the bar; having multiple components to the bar is a fairly large undertaking because I have to muck around with the bar itself.
Contributor
Author
|
|
daniel-goldstein
approved these changes
Oct 18, 2022
added 3 commits
October 18, 2022 16:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a kind of unrelated thing: Fix reading of configuration information to not ignore a hailctl configuration value of
''The big change is to introduce 3 progress bar systems: