[qob] Use one batch for the lifetime of a hl.ServiceBackend #12464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-goldstein
force-pushed
the
qob-pipeline-one-batch
branch
4 times, most recently
from
f6954c6 to
f28e217
Compare
daniel-goldstein
changed the title
daniel-goldstein
force-pushed
the
qob-pipeline-one-batch
branch
from
4a9c845 to
f33c72a
Compare
danking
reviewed
Nov 22, 2022
| progress=progress) | ||
| # FIXME Should we not `print`? | ||
| url = deploy_config.external_url('batch', f'/batches/{self._batch.id}/jobs/{j.job_id}') | ||
| print(f'Submitted to batch {self._batch.id}, see {url}') |
There was a problem hiding this comment.
I'm somewhat inclined to not print. The progress bar should provide all necessary information
There was a problem hiding this comment.
Happy to axe that.
daniel-goldstein
force-pushed
the
qob-pipeline-one-batch
branch
from
ec882a2 to
ee1133a
Compare
danking
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG: When using Query-on-Batch, all jobs for a single hail session are inserted into the same batch instead of one batch per action.