[query] Support zstd compression in BGEN files#12576
Merged
Merged
Conversation
CHANGELOG: `hl.import_bgen` and `hl.export_bgen` now support compression with Zstd.
chrisvittal
previously requested changes
Jan 9, 2023
chrisvittal
left a comment
chrisvittal
left a comment
Collaborator
There was a problem hiding this comment.
One small maintainability issue around the ids for compression.
| assert(compressionCodec == "zlib" || compressionCodec == "zstd") | ||
| val writeHeader = exportType == ExportType.PARALLEL_HEADER_IN_SHARD | ||
| val partWriter = BGENPartitionWriter(tm, entriesFieldName, writeHeader) | ||
| val compressionInt = compressionCodec match { |
Collaborator
There was a problem hiding this comment.
Is there any way to make this some kind of enum, or if that's too much, named constants?
chrisvittal
approved these changes
Jan 12, 2023
danking
pushed a commit
to danking/hail
that referenced
this pull request
Jan 30, 2023
* [query] Support zstd compression in BGEN files CHANGELOG: `hl.import_bgen` and `hl.export_bgen` now support compression with Zstd. * address comments
This was referenced Feb 29, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 30, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG:
hl.import_bgenandhl.export_bgennow support compression with Zstd.