[query] Fix _to_relational for col_key #12583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the col_key.show() issue Dan unearthed.
danking
previously requested changes
Jan 10, 2023
| if self is source.col: | ||
| return None, source.key_cols_by().cols() | ||
| if self is source.col_key: | ||
| return None, source.key_cols_by().cols().select() |
Contributor
There was a problem hiding this comment.
Won't this now produce a warning every time we call _to_relational_..., that seems bad. Can we somehow fix this without triggering the column table is sorted blah blah warning?
Contributor
Author
There was a problem hiding this comment.
initially disagreed, but this should produce an unkeyed thing the same as col. Fixed to select_cols().key_cols_by().cols()
danking
approved these changes
Jan 10, 2023
danking
pushed a commit
to danking/hail
that referenced
this pull request
Jan 30, 2023
* [query] Fix _to_relational for col_key Fixes the col_key.show() issue Dan unearthed. * fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the col_key.show() issue Dan unearthed.