Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Dont use memory service #12784

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

daniel-goldstein
Copy link
Contributor

No description provided.

Copy link
Contributor

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Let's release after this.

@danking
Copy link
Contributor

danking commented Mar 15, 2023

Always good to remove // FIXME: HACK, heh

@danking
Copy link
Contributor

danking commented Mar 15, 2023

FYI, @lgruen we're abandoning the memory service entirely as we've started to experience similar issues to you all as people start to use QoB here at Broad. Daniel has some thoughts on a better cache layer. More soon!

@danking danking merged commit 30767d5 into hail-is:main Mar 15, 2023
danking pushed a commit that referenced this pull request Aug 1, 2023
The memory service has been unused since #12784. Even older clients
should still work if we delete the memory service as the old code path
falls back to blob storage if a request to the memory service fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants