Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG: In Query-on-Batch,
hl.logistic_regression('firth', ...)
is now supported.Forgive me: I cleaned up and unified the look of the (now three)
fit
methods.A few of the sweeping cleanups:
log_lkhd
only evaluated on the last iteration (in particular, its not bound before thecase
)select
as the last step rather thandrop
(we didn't drop all the unnecessary fields previously).select_globals
to make sure we only keep thenull_fit
.Major changes in this PR:
-k firth
).