[query] lower firth regression - #12816
Merged
Merged
Conversation
patrick-schultz
approved these changes
Mar 23, 2023
danking
force-pushed
the
firth-regression
branch
from
March 28, 2023 20:38
cc054de to
1b8305b
Compare
added 9 commits
April 7, 2023 12:25
…est_..._score_epacts, use pytest.approx
danking
force-pushed
the
firth-regression
branch
from
April 7, 2023 16:30
e54ee0d to
89afe50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG: In Query-on-Batch,
hl.logistic_regression('firth', ...)is now supported.Forgive me: I cleaned up and unified the look of the (now three)
fitmethods.A few of the sweeping cleanups:
log_lkhdonly evaluated on the last iteration (in particular, its not bound before thecase)selectas the last step rather thandrop(we didn't drop all the unnecessary fields previously).select_globalsto make sure we only keep thenull_fit.Major changes in this PR:
-k firth).