[fs] Add support for azure https blob urls#12917
Merged
danking merged 13 commits intohail-is:mainfrom Apr 24, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG: ABS blob URIs in the format of
https://<ACCOUNT_NAME>.blob.core.windows.net/<CONTAINER_NAME>/<PATH>are now supported. Thehail-azscheme for referencing blobs in ABS is now deprecated and will be removed in an upcoming release.This PR introduces the https addressing of blobs in ABS and phases out hail-az. The test suite converts completely to testing
https, but both schemes are still supported. We can have confidence that this did not break completely break thehail-azscheme because our test bucket configuration is still usinghail-az(and must until this PR is merged. So some of the test suite + all the service backend tests are flexing thehttpscode path, and then the inter_cloud tests are flexing thehail-azcode path. After this merges, we'll need the following PRshttpsinstead ofhail-azand apply the changes