[qob] maybe retry GSFS reads#13013
Merged
Merged
Conversation
After an `FSSeekableInputStream` method (successfully) returns, `getPosition` always represents the intended location within the object. We can entirely eliminate `lazyPosition` because it tracks the same value as `getPosition` when `reader == null`. For retryable reads, we just seek back to the known correct location of the stream before attempting to read again.
daniel-goldstein
approved these changes
May 10, 2023
Contributor
daniel-goldstein
left a comment
daniel-goldstein
left a comment
There was a problem hiding this comment.
I like the reset on the retryTransientErrors
daniel-goldstein
pushed a commit
to daniel-goldstein/hail
that referenced
this pull request
May 11, 2023
Fixes hail-is#12983 --- After an `FSSeekableInputStream` method (successfully) returns, `getPosition` always represents theintended location within the object. We can entirely eliminate `lazyPosition` because it tracks the same value as `getPosition` when `reader == null`. For retryable reads, we just seek back to the known correct location of the stream before attempting to read again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12983
After an
FSSeekableInputStreammethod (successfully) returns,getPositionalways represents theintended location within the object. We can entirely eliminatelazyPositionbecause it tracks thesame value as
getPositionwhenreader == null.For retryable reads, we just seek back to the known correct location of the stream before attempting to read again.