-
Notifications
You must be signed in to change notification settings - Fork 250
[services] update azure-storage-blob 12.22.0 to mitigate "Stream is already closed" #13032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56f437d
to
d12a12c
Compare
…lready closed" I do not fully understand the Azure git tagging scheme, but [this commit](Azure/azure-sdk-for-java@054df3f) appears to have made `close` idempotent. It was merged in June of 2022. That commit resolved [an issue](Azure/azure-sdk-for-java#24782) reporting an error very similar to our own. All the azure version changes update the Azure packages to their latest versions as of 2023-05-09 1713 ET. Unfortunately, newer Azure versions and Spark 3.3.0 have inconsistent `io.netty` requirements. Spark is stuck back in February 2022. Spark 3.4.0 does support a compatible version of `io.netty`, but we're months from seeing that in Dataproc. This change packages up Azure and all its dependencies into one JAR of relocated classes. We must refer to those classes by their relocated names.
d12a12c
to
9e28c82
Compare
daniel-goldstein
previously approved these changes
May 10, 2023
https://batch.azure.hail.is/batches/3834432/jobs/1 I feel close but its still not working. Now I'm getting some signature mismatch from the server. |
I have no idea what this means
|
The suppressed message is:
|
Oh shit this just means my service account can't write to this bucket. |
🤦 |
daniel-goldstein
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12976
I do not fully understand the Azure git tagging scheme, but this commit appears to have made
close
idempotent. It was merged in June of 2022. That commit resolved an issue reporting an error very similar to our own.All the azure version changes update the Azure packages to their latest versions as of 2023-05-09 1713 ET.
Unfortunately, newer Azure versions and Spark 3.3.0 have inconsistent
io.netty
requirements. Spark is stuck back in February 2022. Spark 3.4.0 does support a compatible version ofio.netty
, but we're months from seeing that in Dataproc.This change packages up Azure and all its dependencies into one JAR of relocated classes. We must refer to those classes by their relocated names.