[query] removes unnecessary serialization in is.hail.rvd.RVD.localSort #13313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iris-garden
force-pushed
the
query/not-serializable
branch
from
27a409e to
f2b2a68
Compare
iris-garden
force-pushed
the
query/not-serializable
branch
from
f2b2a68 to
c8dd25e
Compare
patrick-schultz
approved these changes
Jul 27, 2023
Merged
danking
pushed a commit
to danking/hail
that referenced
this pull request
Jul 27, 2023
tommyli
added a commit
to bioinfomethods/seqr-loading-pipelines
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the current release (0.2.119),
is.hail.rvd.RVD.localSortattempts to serialize an entireis.hail.rvd.RVDobject when called, which causes some operations, like reading a set of VCF files, to fail. That particular operation no longer fails due to some combination of the changes made to reading VCF files in #13206 and #13229, but the serialization could still cause issues ifis.hail.rvd.RVD.localSortis called in another context.See https://hail.zulipchat.com/#narrow/stream/123011-Hail-Query-Dev/topic/Possible.20bug.20in.20Hail.200.2E2.2E119/near/378610151 for more information.