[fs] fix bugs in glob and list in our GSFS #13434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also moved two GSFS-only tests into the FSSuite. There should be very few tests that are cloud-specific.
jigold
previously requested changes
Aug 15, 2023
| } | ||
|
|
||
| @Test def testSeekAfterEOF(): Unit = { | ||
| val prefix = s"$hail_test_storage_uri/google-storage-fs-suite/delete-many-files/${ java.util.UUID.randomUUID() }" |
There was a problem hiding this comment.
can we change the prefix name to not have google in it?
|
There's a bug somewhere in your code in the test suite. |
jigold
approved these changes
Aug 18, 2023
|
Can you add a CHANGELOG for a bug fix for this? |
|
I put the WIP tag on so it won't merge until you change the commit message. |
|
Good catch. I did a bit of digging to confirm the default max results too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG: In QoB, Hail's file systems now correctly list all files in a directory, not just the first 1000. This could manifest in an import_table or import_vcf which used a glob expression. In such a case, only the first 1000 files would have been included in the resulting Table or MatrixTable.
I also moved two GSFS-only tests into the FSSuite. There should be very few tests that are cloud-specific.