-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-dill][hailtop] update past the bad version of dill #13536
Conversation
Can you remind me how these new images get into the hail-vdc artifact registry and on Azure as well? |
Sure! There's a CI build step that copies everything from hailgenetics into the local repo. mirror_hailgenetics_images. Then, in the worker, we notice a limited set of hailgenetics images and, instead of getting them from docker hub, we get them from our internal repositories. |
We only copy if the image isn't already present. I think this code is not what you want in mirror images. We should copy if the contents change as well.
|
ugh, that used to just use copy_image and skopeo did The Right Thing (i.e. copy if it the tag had been updated). |
I'll just manually do this right now. |
Done. |
This inspect command prevents us from updating a tag, for example, if we need to replace an image with a security problem or if there is a bug like the one fixed by hail-is#13536.
And a PR to fix the root cause #13538. |
This inspect command prevents us from updating a tag, for example, if we need to replace an image with a security problem or if there is a bug like the one fixed by #13536.
Fixes #13535.
All the new hailgenetics/dill images are now up: https://hub.docker.com/r/hailgenetics/python-dill/tags