[python-dill][hailtop] update past the bad version of dill#13536
Merged
danking merged 2 commits intohail-is:mainfrom Sep 1, 2023
Merged
[python-dill][hailtop] update past the bad version of dill#13536danking merged 2 commits intohail-is:mainfrom
danking merged 2 commits intohail-is:mainfrom
Conversation
This was referenced Sep 1, 2023
Merged
Contributor
|
Can you remind me how these new images get into the hail-vdc artifact registry and on Azure as well? |
Contributor
Author
|
Sure! There's a CI build step that copies everything from hailgenetics into the local repo. mirror_hailgenetics_images. Then, in the worker, we notice a limited set of hailgenetics images and, instead of getting them from docker hub, we get them from our internal repositories. |
Contributor
|
We only copy if the image isn't already present. I think this code is not what you want in mirror images. We should copy if the contents change as well. |
Contributor
Author
|
ugh, that used to just use copy_image and skopeo did The Right Thing (i.e. copy if it the tag had been updated). |
Contributor
Author
|
I'll just manually do this right now. |
Contributor
Author
|
Done. |
danking
pushed a commit
to danking/hail
that referenced
this pull request
Sep 1, 2023
This inspect command prevents us from updating a tag, for example, if we need to replace an image with a security problem or if there is a bug like the one fixed by hail-is#13536.
Contributor
Author
|
And a PR to fix the root cause #13538. |
jigold
approved these changes
Sep 1, 2023
danking
added a commit
that referenced
this pull request
Sep 1, 2023
This inspect command prevents us from updating a tag, for example, if we need to replace an image with a security problem or if there is a bug like the one fixed by #13536.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13535.
All the new hailgenetics/dill images are now up: https://hub.docker.com/r/hailgenetics/python-dill/tags