Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Allow maximal_independent_set to accept strings as node names #13707

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

chrisvittal
Copy link
Collaborator

@chrisvittal chrisvittal commented Sep 25, 2023

We special case array, converting it before calling unwrapReturn, which for array expects a SJavaArrayString for the return type and an Array[String] for the value.

Fixes #13633

@chrisvittal chrisvittal marked this pull request as ready for review September 25, 2023 19:56
We special case array<str>, converting it before calling unwrapReturn,
which for array<str> expects a SJavaArrayString for the return type and
an Array[String] for the value.
@danking
Copy link
Contributor

danking commented Sep 25, 2023

Nice!

@danking danking merged commit d99c3d1 into hail-is:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[query] hl.maximal_independent_set cannot accept strings as node names
2 participants