[hailtop] yet another transient error #13817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of around 1500 ET 2023-10-16, this exception happens whenever we issue a lot of requests to GCS. See [Zulip thread](https://hail.zulipchat.com/#narrow/stream/300487-Hail-Batch-Dev/topic/cluster.20size/near/396777320).
jigold
previously requested changes
Oct 16, 2023
hail/python/hailtop/utils/utils.py
Outdated
| @@ -687,6 +687,14 @@ def is_transient_error(e): | |||
| if (isinstance(e, aiohttp.ClientPayloadError) | |||
| and e.args[0] == "Response payload is not completed"): | |||
| return True | |||
| if (isinstance(e, aiohttp.ClientOSError) | |||
| and len(e.args) >= 2 | |||
| and e.args[0] == 1 | |||
There was a problem hiding this comment.
This is hard to parse. Should it be e.args[0] == '1' as is e.args[0] a string or int? Can we just check for the message in e.args[1]?
There was a problem hiding this comment.
The first arg is the error number, so it's definitely an integer. I suppose we can be more lax though. I'll change.
jigold
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG: Mitigate new transient error from Google Cloud Storage which manifests as
aiohttp.client_exceptions.ClientOSError: [Errno 1] [SSL: SSLV3_ALERT_BAD_RECORD_MAC] sslv3 alert bad record mac (_ssl.c:2548).As of around 1500 ET 2023-10-16, this exception happens whenever we issue a lot of requests to GCS.
See Zulip thread.