Verify logistic_regression_rows y param is column-indexed#13849
Merged
danking merged 3 commits intoOct 18, 2023
Merged
Conversation
Fixes hail-is#13788: - Add `raise_unless_column_indexed` guard and apply to all column-indexed parameters in `statgen.py`. - Rename `check_row_indexed` and `check_entry_indexed` as I'm allergic to functions called "check" - now it's clearer what they do.
danking
approved these changes
Oct 18, 2023
danking
left a comment
danking
left a comment
Contributor
There was a problem hiding this comment.
Excellent, very thorough fix.
| " found no indices (no source)") | ||
| raise ExpressionException(f"{caller}: expression must be entry-indexed" | ||
| f", found no indices (no source)" | ||
| ) |
| mt = hl.utils.range_matrix_table(2,2) | ||
| mt = mt.annotate_entries(prod = mt.row_idx * mt.col_idx) | ||
|
|
||
| with pytest.raises(hl.ExpressionException): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13788:
raise_unless_column_indexedguard and apply to all column-indexed parameters instatgen.py.check_row_indexedandcheck_entry_indexedas I'm allergic to functions called "check" - now it's clearer what they do.